Skip to content

Add quoted.Expr.{ofSeq, ofList, ofTuple} #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2019
Merged

Add quoted.Expr.{ofSeq, ofList, ofTuple} #7260

merged 2 commits into from
Sep 19, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 19, 2019 •
edited
Loading

  • Improves error messages
  • Improves discovery of method in IDE
  • Remove extension method toExprOfSeq, toExprOfList and toExprOfTuple

@nicolasstucki nicolasstucki changed the title Add quoted.Expr.{ofSeq, ofList} Add quoted.Expr.{ofSeq, ofList, ofTuple} Sep 19, 2019
@nicolasstucki nicolasstucki self-assigned this Sep 19, 2019
@nicolasstucki nicolasstucki force-pushed the move-special-quoted-lifters-inot-expr branch from 2de86fe to 3d340e7 Compare September 19, 2019 11:11
@nicolasstucki
Add quoted.Expr.{ofSeq, ofList}
af1ce41 
Also
* Let `ofList` receive a `Seq`
* Remove `toExprOfSeq` and `toExprOfList`
@nicolasstucki
Add 2 variants of quoted.Expr.ofTuple
97c37bb 
 * `ofTuple` can take a `Seq[Expr[_]]` or specific tuple type
 * Remove `toExprOfTuple` extension method
@nicolasstucki nicolasstucki force-pushed the move-special-quoted-lifters-inot-expr branch from 3d340e7 to 97c37bb Compare September 19, 2019 11:57
@nicolasstucki nicolasstucki marked this pull request as ready for review September 19, 2019 12:42
liufengyun
liufengyun approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I find the readability is much better, no mention better error messages and improvement for member selection in IDE 👍

@nicolasstucki nicolasstucki merged commit 75de330 into scala:master Sep 19, 2019
@nicolasstucki nicolasstucki deleted the move-special-quoted-lifters-inot-expr branch September 19, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun