Enable compiler/* tests for Scala.js

[neshkeev]

The following tests for the compiler/* group enabled:

• compiler/PatMatOuterPointerCheckTest.scala
• compiler/OuterClassTest.scala
• compiler/MatchTest.scala
• compiler/LongTest.scala
• compiler/ArrayTest.scala

Signed-off-by: Nikita Eshkeev [email protected]

[nicolasstucki]

@neshkeev I wonder if it would make sense to convert the whitelist of tests into a blacklist. This could make simpler to enable new tests. Would you have a look at that option? Do you know what is the proportion of tests we run?

[neshkeev]

@nicolasstucki , great idea, I have been thinking about it recently.

Blacklist proposal

I was thinking about introducing a new operator either ^^ or ~~ (dual to **) for inversion of FileFilter, so the this line:

 (dir / "shared/src/test/scala/org/scalajs/testsuite/compiler" ** (("IntTest.scala": FileFilter) || "UnitTest.scala" || "ShortTest.scala" || "PatMatOuterPointerCheckTest.scala" || "OuterClassTest.scala" || "MatchTest.scala" || "LongTest.scala" || "FloatTest.scala" || "DoubleTest.scala" || "CharTest.scala" || "ByteTest.scala" || "BooleanTest.scala" || "ArrayTest.scala")).get

gets translated to this (|| replaced with its canonical dual &&):

 (dir / "shared/src/test/scala/org/scalajs/testsuite/compiler" ~~ (("RegressionTest.scala": FileFilter) && "ReflectiveCallTest.scala")).get

What do you think? Should I convert this proposal to an issue?

About proportion of enabled tests

There are 166 *.scala files in scala-js/test-suite/shared/src/test/scala/org/scalajs/testsuite/ and currently 80 (85 after this PR gets merged) tests (in master) are enabled.
Although there are three directories that have not been processed yet: niobuffer, niocharset, scalalib. They contain 25 *.scala files

Additional

Also I noticed that when a wrong path to a file is specified (due to a typo), then no failures are reported, sbt simply ignores these files, should we do something about it? I would like it to fail tests if a file is not found, otherwise that section will eventually contain non-existing files. What do you think?

[sjrd]

There already exists an operator --, which you can combine with a * pattern on the left and the exclusion list on the right.

About the no failures reported: it is annoying, yes. A blacklist-based thing will help with this issue by construction.

[neshkeev]

@sjrd Thank you for showing this operator, I updated the pull-request

[neshkeev]

@sjrd , please merge this pull-request if possible

[sjrd]

It currently has conflicts.

[neshkeev]

@sjrd , the conflict has been resolved