Fix #7319: Properly support @serialVersionUID #7331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
requested changes
Sep 27, 2019
compiler/src/dotty/tools/backend/jvm/DottyBackendInterface.scala
Outdated
Show resolved
Hide resolved
We need to emit a static `serialVersionUID` field when this annotation is used, but we were missing the logic in DottyBackendInterface to actually retrieve the value of the annotation. I also updated BCodeHelpers to emit the field as private like scalac does since scala/scala@7f20b1c Test cases adapted from scalac.
bishabosha
approved these changes
Sep 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to emit a static
serialVersionUIDfield when this annotationis used, but we were missing the logic in DottyBackendInterface to
actually retrieve the value of the annotation. I also updated
BCodeHelpers to emit the field as private like scalac does since
scala/scala@7f20b1c