Fix #7781: Avoid using nested package definition #7784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to remove `sealed` from `Expr`
Had to remove `sealed` from `Type`
Now that Expr and Type are not sealed these do not need to be in the library
nicolasstucki
requested review from
anatoliykmetyuk and
liufengyun
and removed request for
anatoliykmetyuk
|
I think I have an alternative fix for that |
|
With #7786 this change should be no longer necessary. |
|
Reopened since we won't go ahead with #7786. |
liufengyun
approved these changes
Dec 18, 2019
| @@ -0,0 +1 @@ | |||
| 2: Pattern Match Exhaustivity: _: Expr[Int] | |||
There was a problem hiding this comment.
This is interesting, we don't have the warning before. I'll have a look at it.
There was a problem hiding this comment.
It made sense because Expr is not sealed anymore. The test case was clearly not exhaustive.
There was a problem hiding this comment.
I wonder why the error was not there before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to remove
sealedfromExprandType