Skip to content

Fix issue #8124 #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Fix issue #8124 #8273

wants to merge 11 commits into from

Conversation

michelou
Copy link
Contributor

Also added two tests for dotc and dotd.

Updated behavior with dotd (crashed before fix):

> c:\opt\dotty-0.22.0-RC1\bin\dotd -project -project-url "http://" dummy.scala
-project -project-url "https://" dummy.scala
missing argument for option -project
  dotc -help  gives more information
Site project name not set. Use `-project <title>` to set the project name

Updated behavior with dotc (crashed before fix):

> c:\opt\dotty-0.22.0-RC1\bin\dotc -encoding -d c:\temp\classes dummy.scala
missing argument for option -encoding
  dotc -help  gives more information

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@michelou michelou changed the title Fixed issue #8124 Fix issue #8124 Feb 10, 2020
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your git branch contains unrelated changes in a submodule, this can happen if you git add everything in your branch without first doing a git submodule update (git submodules are not automatically updated). You'll need to revert that change and squash all your commits together

@michelou michelou closed this Feb 10, 2020
@michelou michelou deleted the dotty-t8124 branch February 10, 2020 20:14
@michelou
Copy link
Contributor Author

Replaced by PR #8279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants