Skip to content

Fix #8313: special case typeparamCorrespondsToField #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

OlivierBlanvillain
Copy link
Contributor

Special case typeparamCorrespondsToField to scala.*:. Since *: is artificially added to tuples, we also need to special case that logic to conclude that *:[A, _] and *:[B, _] are disjoint when knowing that A and B are disjoint.

@@ -2193,13 +2193,15 @@ class TypeComparer(initctx: Context) extends ConstraintHandling[AbsentContext] w
/** Returns last check's debug mode, if explicitly enabled. */
def lastTrace(): String = ""

/** Does `tycon` has a field with type `tparam`? Special cased for `scala.*:`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has -> have

@odersky odersky assigned OlivierBlanvillain and unassigned odersky Mar 6, 2020
@OlivierBlanvillain OlivierBlanvillain merged commit dcf7cf4 into scala:master Mar 9, 2020
@OlivierBlanvillain OlivierBlanvillain deleted the fix-8313 branch March 9, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants