Skip to content

Fix diff utils for coloring #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2020
Merged

Fix diff utils for coloring #8989

merged 2 commits into from
May 18, 2020

Conversation

rethab
Copy link
Contributor

@rethab rethab commented May 16, 2020 •
edited
Loading

besides the fix for #8980, other changes are also colored more "aggressively" now:

before:
tuple-coloring-before
after:
tuple-coloring-after

rethab added 2 commits May 16, 2020 21:36
@rethab
add tests for DiffUtil
80943ee
@rethab
increase score points for equality in needleman-wunsch, fixes scala#8980
5c75d47 


  * increasing the score fixes a subtle coloring issue where a closing
    square bracket would erroneously classified as deleted instead of
    matching.
dottybot
dottybot reviewed May 16, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@nicolasstucki nicolasstucki self-requested a review May 16, 2020 19:41
@nicolasstucki nicolasstucki linked an issue May 18, 2020 that may be closed by this pull request
Type diff in tuples is wrongly colored #8980
Closed
@nicolasstucki nicolasstucki merged commit 59fcde7 into scala:master May 18, 2020
@nicolasstucki
Copy link
Contributor

Thank you @rethab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type diff in tuples is wrongly colored
3 participants
@rethab @nicolasstucki @dottybot