Skip to content

Avoid cycle between Java static class and outer class #9121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Jun 7, 2020

Real world usecase is
https://www.javadoc.io/doc/software.amazon.awssdk/cloudwatchlogs/2.13.28/software/amazon/awssdk/services/cloudwatchlogs/model/GetLogEventsRequest.html

  • When parsing a Java classfile, set the info of the companion (where
    inner static classes will be looked up) before reading the generic
    signature of the class.
  • When looking for a companion, do not unnecessarily force denotations

Real world usecase is
https://www.javadoc.io/doc/software.amazon.awssdk/cloudwatchlogs/2.13.28/software/amazon/awssdk/services/cloudwatchlogs/model/GetLogEventsRequest.html

- When parsing a Java classfile, set the info of the companion (where
  inner static classes will be looked up) before reading the generic
  signature of the class.
- When looking for a companion, do not unnecessarily force denotations
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit f49b95f into scala:master Jun 8, 2020
@liufengyun liufengyun deleted the fix-static-cycle branch June 8, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants