Don't use a special representation for Java enum values #9930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Java, annotation arguments must be constants, so enum values are treated specially. In Scala, annotation arguments can be whatever tree we want, so we don't really need to represent them as `Literal(Constant(enumValueSymbol))` and can just use a `TermRef` to the enum value instead. This commit implements this change, this has several advantages compared to the status quo: - The handling of Java enum values and Scala enum values is now less different. - We can drop the handling of symbols in `Constant` - ... and therefore remove one tag from Tasty. - In turn, this means we don't have to worry about how to expose this in tasty-reflect. This commit breaks the Tasty format and therefore bump its major version to 24.
smarter
force-pushed
the
remove-enum-constant
branch
from
9eb5f10 to
ab257d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java, annotation arguments must be constants, so enum values are
treated specially. In Scala, annotation arguments can be whatever tree
we want, so we don't really need to represent them as
Literal(Constant(enumValueSymbol))and can just use aTermRefto theenum value instead.
This commit implements this change, this has several advantages compared
to the status quo:
different.
Constantthis in tasty-reflect.
This commit breaks the Tasty format and therefore bump its major version
to 24.