-
Notifications
You must be signed in to change notification settings - Fork 86
day 14 article #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
day 14 article #822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I'm surprised no one took this day, it was one of my favourites this year.
Comments are minor, may help add some clarity.
The christmas trees I know are really tall, but only in a few columns. So let's test the vertical columns for a few lines that are really long. | ||
They also have a lot of shorter horizontal lines, so let's also check the rows for a lot of shorter lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another assumption here is that the tree itself is solid; made up of many robots adjacent to each other. It's not like, an outline of a tree shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how it would be possible to detect that if that was the case. Probably something along the lines of a flood fill but that would cost too much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, yeah. I meant moreso it's worth being explicit and listing it as an assumption here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added section beforehand specifying assumption being made
thank you! |
Hello, you should make sure that the other person who reserved this one doesn't still want to write it. I forgot about this for a week |
No one wrote an article for day 14 (which I kind of understand, it sucked).
I decided to write a new one that SHOULD be followable from someone who doesn't know what the final result will look like.
I want reviewers to think like someone who hasn't seen the Christmas tree output before because it's really important that you don't need to know what it looks like to get to my result.
I also removed my writeup link here.