Escape spaces in project path #37
Conversation
…hat scalatest can find them.
|
Fixes #38 |
| @@ -426,12 +427,37 @@ private ClassLoader classLoader() { | |||
| } | |||
|
|
|||
| private List<String> runpath() { | |||
There was a problem hiding this comment.
The main fix is in this method.
Remove integration tests broken after Scala upgrade, again
|
Adding an integration test for the fix in this PR. (They were removed in an earlier PR: #40) |
|
@gcberger I tested version 2.0.0-SNAPSHOT and it still doesn't build project that have spaces in their path. This PR fixes the issue, and I would appreciate it if it were considered for release in 2.0.0. |
|
@cstroe you're PR came in after we had gone through the PRs for 2.0.0, which is why it didn't get in there. Doesn't mean we can't consider it. I'll take a look at your PR tomorrow while people are trying out the SNAPSHOT. |
|
@bvenners Any chance in merging this? |
|
We just ran into this issue, chance of getting fix merged? @bvenners status? |
|
@cstroe Sorry for the long delay on this PR. Do you mind signing our CLA? It is here: |
|
@bvenners I have signed the CLA and emailed it. |
|
Just ran into this issue. Is this still on track to be merged? What would a patch be to get around this issue in the mean time?? |
src/main/java/org/scalatest/tools/maven/AbstractScalaTestMojo.java
Outdated
Show resolved
Hide resolved
|
LGTM |
This allows scalatest-maven-plugin to run projects that have a space in their path.
In the process, I had to update the integration tests so that they run correctly (the lift integration test wasn't compiling its scala files) and properly verify that scalatest actually ran tests.