Fixes #57 using un-modifyable lists & judicious synchronization #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there... any thoughts on merging this? |
|
@chrisalbright looks like you have a merge conflict, not sure if you saw that come up |
|
@Rdefreitas thanks for the head's up. I don't recall seeing this when I opened the PR, but it should be ok now. |
|
@Rdefreitas do you have any ideas on how I can help move this forward? Is this project abandoned? |
|
@chrisalbright not abandoned, just moving in a bit of slow motion. @katrinsharp has been working on it lately, and we should have a release soon. |
|
Hi, @bvenners and @katrinsharp - just checking in here. Any motion on this PR? |
|
@chrisalbright yes today/tomorrow. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just ensuring lists are un-modifyable. Added synchronization to the side-effect code which creates a directory if it doesn't exist. Not sure how to test this, but in the build that inspired this change, the warnings are gone, and all is well.