Skip to content

feat(baremetal): add support for add flexible ip #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Laure-di
Copy link
Contributor

close #2883

@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch 2 times, most recently from 9ce2c5f to 8dda87b Compare February 21, 2024 16:31
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch from 8dda87b to 47dc3eb Compare February 22, 2024 09:22
@Laure-di Laure-di marked this pull request as draft February 22, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 77.43%. Comparing base (5bf53e0) to head (04b237c).
Report is 27 commits behind head on master.

Files Patch % Lines
...ernal/namespaces/baremetal/v1/custom_server_fip.go 86.56% 6 Missing and 3 partials ⚠️
...amespaces/baremetal/v1/custom_server_fip_prompt.go 61.90% 5 Missing and 3 partials ⚠️
internal/interactive/list.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
+ Coverage   75.45%   77.43%   +1.98%     
==========================================
  Files         202      209       +7     
  Lines       44323    38302    -6021     
==========================================
- Hits        33444    29661    -3783     
+ Misses       9653     7376    -2277     
- Partials     1226     1265      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch 6 times, most recently from 9b7f5b5 to 541ced3 Compare February 28, 2024 15:11
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch 10 times, most recently from dace493 to 56d0505 Compare March 4, 2024 14:31
@Laure-di Laure-di marked this pull request as ready for review March 4, 2024 14:40
@remyleone remyleone added elastic-metal Elastic-metal issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests labels Apr 10, 2024
@remyleone remyleone added the priority:highest Bugs filled by customers, security issues label Apr 10, 2024
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch 2 times, most recently from 7bdbfba to eaf1998 Compare April 16, 2024 14:07
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch from 80f183f to 65cf1d8 Compare April 16, 2024 15:39
@Laure-di Laure-di marked this pull request as draft April 16, 2024 19:14
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch 3 times, most recently from 04b237c to 42db2c0 Compare April 17, 2024 10:04
@Laure-di Laure-di marked this pull request as ready for review April 17, 2024 10:46
@remyleone remyleone enabled auto-merge April 18, 2024 08:54
@Laure-di Laure-di force-pushed the feat/add-support-for-add-flexible-ip branch from 42db2c0 to d7a4006 Compare April 18, 2024 09:14
@remyleone remyleone added this pull request to the merge queue Apr 18, 2024
Merged via the queue into scaleway:master with commit 141fdb1 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elastic-metal Elastic-metal issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for add-flexible-ip
3 participants