-
Notifications
You must be signed in to change notification settings - Fork 152
feat(baremetal): add support for add flexible ip #3670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
remyleone
merged 7 commits into
scaleway:master
from
Laure-di:feat/add-support-for-add-flexible-ip
Apr 18, 2024
Merged
feat(baremetal): add support for add flexible ip #3670
remyleone
merged 7 commits into
scaleway:master
from
Laure-di:feat/add-support-for-add-flexible-ip
Apr 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ce2c5f
to
8dda87b
Compare
remyleone
reviewed
Feb 21, 2024
8dda87b
to
47dc3eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3670 +/- ##
==========================================
+ Coverage 75.45% 77.43% +1.98%
==========================================
Files 202 209 +7
Lines 44323 38302 -6021
==========================================
- Hits 33444 29661 -3783
+ Misses 9653 7376 -2277
- Partials 1226 1265 +39 ☔ View full report in Codecov by Sentry. |
9b7f5b5
to
541ced3
Compare
dace493
to
56d0505
Compare
7bdbfba
to
eaf1998
Compare
remyleone
reviewed
Apr 16, 2024
80f183f
to
65cf1d8
Compare
04b237c
to
42db2c0
Compare
remyleone
approved these changes
Apr 18, 2024
42db2c0
to
d7a4006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
elastic-metal
Elastic-metal issues, bugs and feature requests
flexible-ip
Flexible IP issues, bugs and feature requests
priority:highest
Bugs filled by customers, security issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2883