Skip to content

feat: change no constructed context values to error #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

DorianMaliszewski
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #383 (4205751) into master (4c6230d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          360       360           
  Branches        60        60           
=========================================
  Hits           360       360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6230d...4205751. Read the comment docs.

Copy link
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a feat I think :)

@DorianMaliszewski DorianMaliszewski changed the title fix: change no constructed context values to error feat: change no constructed context values to error Sep 16, 2021
@DorianMaliszewski DorianMaliszewski merged commit 94eb4e3 into master Sep 16, 2021
@DorianMaliszewski DorianMaliszewski deleted the feat/no-constructed-context-values-error branch September 16, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants