Skip to content

feat(jest-helpers): add jest-helpers package #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 14, 2021
Merged

Conversation

QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Oct 13, 2021

Summary

Reviewers:

  1. @matthprost

  2. @DorianMaliszewski

Ping:

(If you want to ping somebody involved in this MR without requesting reviews)

  1. @philibea

Summarize the feature concisely:

What is expected?

Add a new jest-helpers package to generate few helper methods instead of duplicating them in different projects.

Does this introduce a consequent breaking change?

No

@QuiiBz QuiiBz added the enhancement New feature or request label Oct 13, 2021
@QuiiBz QuiiBz self-assigned this Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #432 (750de15) into master (b59a375) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        15    +4     
  Lines          448       473   +25     
  Branches        71        75    +4     
=========================================
+ Hits           448       473   +25     
Impacted Files Coverage Δ
...kages/jest-helpers/src/helpers/renderWithTheme.tsx 100.00% <100.00%> (ø)
...-helpers/src/helpers/shouldMatchEmotionSnapshot.ts 100.00% <100.00%> (ø)
...rc/helpers/shouldMatchEmotionSnapshotWithPortal.ts 100.00% <100.00%> (ø)
packages/jest-helpers/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59a375...750de15. Read the comment docs.

@QuiiBz QuiiBz marked this pull request as ready for review October 13, 2021 09:33
@QuiiBz QuiiBz merged commit 2513fab into master Oct 14, 2021
@QuiiBz QuiiBz deleted the feat/jest-helpers branch October 14, 2021 07:53
@QuiiBz QuiiBz restored the feat/jest-helpers branch October 25, 2021 08:18
@chambo-e chambo-e deleted the feat/jest-helpers branch March 4, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants