Skip to content

feat(dom): add more filters on ListDNSZones to ease VPC sync #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/clients/src/api/domain/v2beta1/api.gen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ export class API extends ParentAPI {
method: 'GET',
path: `/domain/v2beta1/dns-zones`,
urlParams: urlParams(
['created_after', request.createdAfter],
['created_before', request.createdBefore],
['dns_zone', request.dnsZone],
['dns_zones', request.dnsZones],
['domain', request.domain],
['order_by', request.orderBy ?? 'domain_asc'],
['organization_id', request.organizationId],
Expand All @@ -181,6 +184,8 @@ export class API extends ParentAPI {
request.pageSize ?? this.client.settings.defaultPageSize,
],
['project_id', request.projectId],
['updated_after', request.updatedAfter],
['updated_before', request.updatedBefore],
),
},
unmarshalListDNSZonesResponse,
Expand Down
18 changes: 16 additions & 2 deletions packages/clients/src/api/domain/v2beta1/types.gen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ export type ListDNSZonesRequestOrderBy =
| 'domain_desc'
| 'subdomain_asc'
| 'subdomain_desc'
| 'created_at_asc'
| 'created_at_desc'
| 'updated_at_asc'
| 'updated_at_desc'

export type ListDomainsRequestOrderBy = 'domain_asc' | 'domain_desc'

Expand Down Expand Up @@ -848,8 +852,18 @@ export type ListDNSZonesRequest = {
pageSize?: number
/** Domain on which to filter the returned DNS zones. */
domain: string
/** DNS zone on which to filter the returned DNS zones. */
dnsZone: string
/** @deprecated DNS zone on which to filter the returned DNS zones. */
dnsZone?: string
/** DNS zones on which to filter the returned DNS zones. */
dnsZones?: string[]
/** Only list DNS zones created after this date. */
createdAfter?: Date
/** Only list DNS zones created before this date. */
createdBefore?: Date
/** Only list DNS zones updated after this date. */
updatedAfter?: Date
/** Only list DNS zones updated before this date. */
updatedBefore?: Date
}

export type CreateDNSZoneRequest = {
Expand Down