Skip to content

fix(framework): base64 encoded response were not being decoded #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2024
Merged

fix(framework): base64 encoded response were not being decoded #137

merged 7 commits into from
Jul 24, 2024

Conversation

cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Jul 24, 2024 •
edited
Loading

Summary

What's changed?

  • Added support for the isBase64EncodedResponse property
  • Added example to showcase change
  • Bumped version to 1.1.2 to prepare release

Why do we need this?

  • We should support base64 encoded response

How have you tested it?

  • Added a simple unit test ✅
  • Example is returning a cat picture ✅

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

@cyclimse cyclimse self-assigned this Jul 24, 2024
@cyclimse cyclimse marked this pull request as ready for review July 24, 2024 09:47
@cyclimse cyclimse requested review from norbjd and Bemilie July 24, 2024 09:47
@cyclimse cyclimse closed this Jul 24, 2024
@cyclimse cyclimse reopened this Jul 24, 2024
Bemilie
Bemilie approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Bemilie Bemilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

norbjd
norbjd approved these changes Jul 24, 2024
View reviewed changes
Copy link

@norbjd norbjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit in examples/package-lock.json, the version 1.1.1 of serverless-functions-node seems hardcoded, so I'm not really sure how it will behave if someone clones the repo to run the example. Will it take the version 1.1.1 without the fix?

@cyclimse cyclimse force-pushed the fix/base64-encoding-in-response-is-not-working branch from 7c184e6 to 4049916 Compare July 24, 2024 13:36
@cyclimse cyclimse merged commit 1186a09 into main Jul 24, 2024
46 checks passed
@cyclimse cyclimse deleted the fix/base64-encoding-in-response-is-not-working branch July 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbjd norbjd norbjd approved these changes

@Bemilie Bemilie Bemilie approved these changes

Assignees

@cyclimse cyclimse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyclimse @norbjd @Bemilie