Skip to content

tests(redis): remove cluster size changes #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2024
Merged

tests(redis): remove cluster size changes #2706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbb45ec
tests(redis): remove cluster size changes
Codelax Aug 20, 2024
a43f24f
record cassettes
Codelax Aug 20, 2024
7cdcc30
Merge branch 'master' into tests/redis-extra-sizes
Laure-di Aug 23, 2024
b82b52e
Merge branch 'master' into tests/redis-extra-sizes
jremy42 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions internal/services/redis/cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,36 +218,6 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) {
acctest.CheckResourceIDChanged("scaleway_redis_cluster.main", &clusterID),
),
},
{
Config: fmt.Sprintf(`
resource scaleway_vpc_private_network private_network {}

resource "scaleway_redis_cluster" "main" {
name = "test_redis_migrate_cluster_size_ipam"
version = "%s"
node_type = "RED1-XS"
user_name = "my_initial_user"
password = "thiZ_is_v&ry_s3cret"
cluster_size = 5
tls_enabled = "true"
private_network {
id = scaleway_vpc_private_network.private_network.id
}
}
`, latestRedisVersion),
Check: resource.ComposeTestCheckFunc(
isClusterPresent(tt, "scaleway_redis_cluster.main"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_ipam"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "5"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
acctest.CheckResourceIDPersisted("scaleway_redis_cluster.main", &clusterID),
),
},
},
})
}
Expand Down Expand Up @@ -338,48 +308,6 @@ func TestAccCluster_MigrateClusterSizeWithStaticEndpoint(t *testing.T) {
acctest.CheckResourceIDChanged("scaleway_redis_cluster.main", &clusterID),
),
},
{
Config: fmt.Sprintf(`
resource scaleway_vpc_private_network private_network {}

resource "scaleway_redis_cluster" "main" {
name = "test_redis_migrate_cluster_size_static"
version = "%s"
node_type = "RED1-XS"
user_name = "my_initial_user"
password = "thiZ_is_v&ry_s3cret"
cluster_size = 5
tls_enabled = "true"
private_network {
id = scaleway_vpc_private_network.private_network.id
service_ips = [
"192.168.99.1/24",
"192.168.99.2/24",
"192.168.99.3/24",
"192.168.99.4/24",
"192.168.99.5/24",
]
}
}
`, latestRedisVersion),
Check: resource.ComposeTestCheckFunc(
isClusterPresent(tt, "scaleway_redis_cluster.main"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "name", "test_redis_migrate_cluster_size_static"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "version", latestRedisVersion),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "node_type", "RED1-XS"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "user_name", "my_initial_user"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "password", "thiZ_is_v&ry_s3cret"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "cluster_size", "5"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "tls_enabled", "true"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.0", "192.168.99.1/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.1", "192.168.99.2/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.2", "192.168.99.3/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.3", "192.168.99.4/24"),
resource.TestCheckResourceAttr("scaleway_redis_cluster.main", "private_network.0.service_ips.4", "192.168.99.5/24"),
resource.TestCheckResourceAttrPair("scaleway_redis_cluster.main", "private_network.0.id", "scaleway_vpc_private_network.private_network", "id"),
acctest.CheckResourceIDPersisted("scaleway_redis_cluster.main", &clusterID),
),
},
},
})
}
Expand Down
3,919 changes: 2,113 additions & 1,806 deletions internal/services/redis/testdata/cluster-acl.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4,616 changes: 2,650 additions & 1,966 deletions internal/services/redis/testdata/cluster-basic.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2,796 changes: 1,472 additions & 1,324 deletions internal/services/redis/testdata/cluster-certificate.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

5,262 changes: 3,138 additions & 2,124 deletions internal/services/redis/testdata/cluster-endpoints-cluster-mode.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

11,117 changes: 5,051 additions & 6,066 deletions ...nal/services/redis/testdata/cluster-migrate-cluster-size-with-ipam-endpoint.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

11,264 changes: 5,198 additions & 6,066 deletions ...l/services/redis/testdata/cluster-migrate-cluster-size-with-static-endpoint.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

6,163 changes: 3,779 additions & 2,384 deletions internal/services/redis/testdata/cluster-migrate.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2,233 changes: 1,325 additions & 908 deletions internal/services/redis/testdata/cluster-no-certificate.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4,164 changes: 2,260 additions & 1,904 deletions internal/services/redis/testdata/cluster-settings.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading