Skip to content

feat(baremetal): read private ips #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented May 5, 2025

This PR adds the private_ips exported field to the schema of a baremetal server.

Left to-do:

  • Apply suggestions from previous PR review

@Mia-Cross Mia-Cross self-assigned this May 5, 2025
@Mia-Cross Mia-Cross closed this May 5, 2025
@Mia-Cross Mia-Cross reopened this May 5, 2025
@Mia-Cross Mia-Cross force-pushed the baremetal_read_private_ips branch from 9301f0c to ce54f2e Compare May 5, 2025 21:31
@Mia-Cross Mia-Cross marked this pull request as ready for review May 5, 2025 21:51
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners May 5, 2025 21:51
@Mia-Cross Mia-Cross marked this pull request as draft May 5, 2025 22:03
@Mia-Cross Mia-Cross force-pushed the baremetal_read_private_ips branch from fa743dd to c0757a9 Compare May 6, 2025 15:02
@Mia-Cross Mia-Cross force-pushed the baremetal_read_private_ips branch from 61d2658 to d7dbf49 Compare May 6, 2025 15:49
@Mia-Cross Mia-Cross marked this pull request as ready for review May 6, 2025 15:50
@remyleone remyleone added this pull request to the merge queue May 13, 2025
Merged via the queue into scaleway:master with commit dbcbc4f May 13, 2025
45 checks passed
@Mia-Cross Mia-Cross deleted the baremetal_read_private_ips branch May 13, 2025 08:58
jremy42 pushed a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants