Skip to content

chore(k8s): migrate to context based workflow #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

chore(k8s): migrate to context based workflow #619

merged 2 commits into from
Oct 12, 2020

Conversation

remyleone
Copy link
Member

No description provided.

Sh4d1
Sh4d1 suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some calls missing ctx like listversions in the helpers file and upgrade request. The wait for as well

@remyleone
Copy link
Member Author

scaleway/scaleway-sdk-go#575

Sh4d1
Sh4d1 previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sh4d1
Sh4d1 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 9e65e4f into scaleway:master Oct 12, 2020
@remyleone remyleone deleted the context_k8s branch October 12, 2020 13:30
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees
No one assigned
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remyleone @Sh4d1