feat(vpc): add support for private network, private nic #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-quere
reviewed
Nov 3, 2020
jerome-quere
reviewed
Nov 3, 2020
jerome-quere
reviewed
Nov 3, 2020
jerome-quere
suggested changes
Nov 3, 2020
jerome-quere
suggested changes
Nov 10, 2020
This adds the support of VPC resources, data sources and instance private NIC dependancy. The private NIC resource id has an unusual format like: zone/server_uuid/private_nic_uuid this is due to the implementation of the private NIC endpoint .../v1/zone/servers/server_id/private-nics/private_nic_id thus the SDK. So we have to store the server ID within the private NIC resource ID. Additional helpers for parsing/building a this new format of resource ID called NestedID have been added. Signed-off-by: Amine Kherbouche <[email protected]>
Signed-off-by: Amine Kherbouche <[email protected]>
jerome-quere
approved these changes
Nov 17, 2020
Closed
1 task
remyleone
added
the
vpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the support of VPC resources, data sources, and instance private NIC dependency.
The private NIC resource id has an unusual format like:
zone/server_uuid/private_nic_uuid
this is due to the implementation of the private NIC endpoint
.../v1/zone/servers/server_id/private-nics/private_nic_idthus the SDK.
So we have to store the server ID within the private NIC resource ID.
Additional helpers for parsing/building to this new format of resource ID called NestedID have been added.