Skip to content

fix warning. use onComplete instead of onSuccess and onFailure #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2019
Merged

fix warning. use onComplete instead of onSuccess and onFailure #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/src/main/scala/scalikejdbc/async/AsyncDBSession.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import scala.concurrent._
import scalikejdbc._
import scalikejdbc.GlobalSettings._
import scala.collection.mutable.LinkedHashMap
import scala.util.{ Failure, Success }
import scalikejdbc.async.ShortenedNames._
import java.sql.PreparedStatement
import scalikejdbc.async.internal.MockPreparedStatement
Expand Down Expand Up @@ -622,12 +623,13 @@ trait AsyncDBSession extends LogSupport {

protected def withListeners[A](statement: String, parameters: Seq[Any], startMillis: Long = System.currentTimeMillis)(
f: Future[A])(implicit cxt: EC = EC.global): Future[A] = {
f.onSuccess {
case _ =>
f.onComplete {
case Success(_) =>
val millis = System.currentTimeMillis - startMillis
GlobalSettings.queryCompletionListener.apply(statement, parameters, millis)
case Failure(e) =>
GlobalSettings.queryFailureListener.apply(statement, parameters, e)
}
f.onFailure { case e: Throwable => GlobalSettings.queryFailureListener.apply(statement, parameters, e) }
f
}

Expand Down