Skip to content

Add community guide #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2023

Conversation

juanis2112
Copy link
Member

Co-authored-by: Sanket Verma [email protected]
Co-authored-by: Inessa Pawson [email protected]

@netlify
Copy link

netlify bot commented May 27, 2023

Deploy Preview for learn-scientific-python-org failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit cc33cde
🔍 Latest deploy log https://app.netlify.com/sites/learn-scientific-python-org/deploys/64715932144a8f0008f67525

Co-authored-by: Sanket Verma <[email protected]>
Co-authored-by: Inessa Pawson <[email protected]>
@juanis2112 juanis2112 marked this pull request as ready for review May 27, 2023 01:13
Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first draft. Thank you, @juanis2112 and @MSanKeys963!

@InessaPawson InessaPawson merged commit d3d0469 into scientific-python:main May 28, 2023
@sanketverma1704 sanketverma1704 mentioned this pull request May 28, 2023
@sanketverma1704
Copy link
Member

I think this PR needs some fixing. The CI is failing, and I can't see the content over at https://learn.scientific-python.org/community/.

I tried fixing pre-commit errors in #59, but some tests are failing. Any ideas?

CC: @juanis2112 @jarrodmillman @stefanv

@jarrodmillman
Copy link
Member

@InessaPawson We should make sure that the CI is passing before merging PRs. I will fix this in @MSanKeys963 PR #59. Thanks!!

@juanis2112
Copy link
Member Author

I think it just need rebasing since I don’t think I had in my branch the changes added to build the developers guide @jarrodmillman @MSanKeys963

@stefanv
Copy link
Member

stefanv commented May 30, 2023

I think it just need rebasing

Here's a list of the changes @jarrodmillman had to make to get it to pass.

@juanis2112
Copy link
Member Author

Sorry @jarrodmillman. I’m pretty sure I ran the pre-commit and wasn’t expecting it to have so many errors.
Also @stefanv we were working with jarrod during the summit and he was helping me fix the PR but we never got to fixing it. After a while of looking at the errors Jarrod suggested that it was probably due to my PR being behind the main branch after the scikit hep guide changes were merged. Hence I thought that’s what was wrong with the PR.

@stefanv
Copy link
Member

stefanv commented May 30, 2023

Hehe, yeap, I caused a bit of trouble there, but all good---it's sorted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants