-
Notifications
You must be signed in to change notification settings - Fork 17
Add community guide #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add community guide #58
Conversation
❌ Deploy Preview for learn-scientific-python-org failed.Built without sensitive environment variables
|
Co-authored-by: Sanket Verma <[email protected]> Co-authored-by: Inessa Pawson <[email protected]>
31d7f3b
to
cc33cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first draft. Thank you, @juanis2112 and @MSanKeys963!
I think this PR needs some fixing. The CI is failing, and I can't see the content over at https://learn.scientific-python.org/community/. I tried fixing pre-commit errors in #59, but some tests are failing. Any ideas? |
@InessaPawson We should make sure that the CI is passing before merging PRs. I will fix this in @MSanKeys963 PR #59. Thanks!! |
I think it just need rebasing since I don’t think I had in my branch the changes added to build the developers guide @jarrodmillman @MSanKeys963 |
Here's a list of the changes @jarrodmillman had to make to get it to pass. |
Sorry @jarrodmillman. I’m pretty sure I ran the pre-commit and wasn’t expecting it to have so many errors. |
Hehe, yeap, I caused a bit of trouble there, but all good---it's sorted :) |
Co-authored-by: Sanket Verma [email protected]
Co-authored-by: Inessa Pawson [email protected]