This repository was archived by the owner on Jan 9, 2023. It is now read-only.
mention progress bar usage of read_root in README #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
reviewed
Oct 29, 2018
|
|
||
| # or | ||
| from tqdm import tqdm | ||
| for df in tqdm(read_root('bigfile.root', chunksize=100000), unit="chunks"): |
There was a problem hiding this comment.
Just changing this to be consistent (and trying out the GitHub suggestion feature).
Suggested change
| for df in tqdm(read_root('bigfile.root', chunksize=100000), unit="chunks"): | |
| for df in tqdm(read_root('bigfile.root', chunksize=100000), unit='chunks'): |
There was a problem hiding this comment.
As I don't have permission to push to this branch I'll merge and apply the suggestion manually.
Thanks for the PR 👍
There was a problem hiding this comment.
oh, i just clicked apply to see if it works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion by @eduardo-rodrigues in #75