Skip to content

MNT remove requirements files and move it in setup.py #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2021
Merged

MNT remove requirements files and move it in setup.py #816

merged 3 commits into from
Feb 18, 2021

Conversation

glemaitre
Copy link
Member

closes #810

Remove the requirements file in favour of extras_require in setup.py.

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2021 •
edited
Loading

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 23:11: F821 undefined name 'version'

Comment last updated at 2021-02-17 21:17:01 UTC

@glemaitre glemaitre merged commit 76abfa4 into scikit-learn-contrib:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies and requirement files
2 participants
@glemaitre @pep8speaks