Skip to content

SLEP011 Do not make mandatory TC vote during SLEP vote #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

glemaitre
Copy link
Member

No description provided.

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually addressing a problem? Is it worth making such changes preemptively?

@adrinjalali
Copy link
Member

For instance, with the resampler SLEP, there needs to be two SLEPs proposing the two solutions, and if one of the is rejected, we don't necessarily want the TC to have to be involved, the slep author can go and modify or have a new one or something. Discussing what will happen in the case of the sleps we already have yesterday, we realized this is an issue which needs to be fixed.

@GaelVaroquaux
Copy link
Member

I'm overall fine with the principle of this suggestion. It is a good one!

@amueller
Copy link
Member

Not sure if this is our most urgent issue but I'm also ok with it

@adrinjalali
Copy link
Member

@glemaitre could you also add this to the under review maybe? we can then merge and call the vote.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Adrin said, add the link to under review and change the status in the header. LGTM

########

"[...] If no option can gather two thirds of the votes cast, the decision is
escalated to the TC **if the SLEP proposer would like the SLEP to be accepted**, which in turn will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long

@amueller
Copy link
Member

amueller commented Feb 3, 2020

The current governance document doesn't require a vote if there is consensus. We have voted on previous SLEPs but there's not really any need to vote for this one, I feel.

@adrinjalali
Copy link
Member

The current governance document doesn't require a vote if there is consensus. We have voted on previous SLEPs but there's not really any need to vote for this one, I feel.

That's an interesting point, which makes it possible to make important decisions w/o announcing on the mailing list beforehand. Might be a bug, not a feature :P

@amueller
Copy link
Member

amueller commented Feb 4, 2020

You think it is? Well then we should... probably fix that first lol?
Add a sentence "before any SLEP is accepted it should be announced on the mailing list"?

@amueller
Copy link
Member

amueller commented Feb 4, 2020

Actually, rereading, I think the governance doc is not clear on whether a vote is required :(
I thought the intent was to require a vote only if there is disagreement.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Feb 4, 2020 via email

@amueller
Copy link
Member

amueller commented Feb 4, 2020

@GaelVaroquaux did you understand the governance document as always requiring a vote for a SLEP?

@rth
Copy link
Member

rth commented Feb 4, 2020

As a side comment, making votes for SLEPs on the mailing list, especially when there is unanimous agreement and all discussion happened in the PR is probably not very relevant for most subscribed users. For most I imagine it's just noise, which will not help in keeping users subscribed/interested.

I get that we need some public and temper proof way to record votes, but I wonder if the user mailing list is the best place for it.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Feb 4, 2020 via email

@adrinjalali
Copy link
Member

This is an alternative path to reduce noise on the mailing list:

  • merge a SLEP as under review
  • create a PR to move the SLEP as accepted
  • send an email, and ask core-devs to vote on the PR

########

This SLEP proposes a change in the decision making process. It proposes to not
always call for a TC vote in case that no consensus is found during the vote of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
always call for a TC vote in case that no consensus is found during the vote of
always call for a Technical Committee (TC) vote in case that no consensus is found during the vote of

@glemaitre
Copy link
Member Author

I made the changes. I think the proposal of @adrinjalali is what I would expect.
We should probably fix these issues as well. What is the path then?

@adrinjalali
Copy link
Member

I don't think we need to change anything since the governance model doesn't really specify how it should be done. I'd say we merge, create the next PR to move it as accepted, and call the vote on the mailing list.

@amueller
Copy link
Member

So should we merge this? Or 000?

@GaelVaroquaux
Copy link
Member

With regards to merging this SLEP, I fear that, in it's current state it would add an extra layer of stuff to read. In other terms, I think that we need to consolidate the information somewhere, elsewhere people will have to dig for this information through many layers. Where is that somewhere, I am not certain. Maybe SLEP 000 is a good way to doing that.

@glemaitre
Copy link
Member Author

So let's focus on SLEP000 and come back once we have something solid.

@glemaitre glemaitre closed this Feb 16, 2020
@GaelVaroquaux
Copy link
Member

I think that this is a pragmatic view! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants