-
-
Notifications
You must be signed in to change notification settings - Fork 34
SLEP011 Do not make mandatory TC vote during SLEP vote #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
Co-Authored-By: Adrin Jalali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually addressing a problem? Is it worth making such changes preemptively?
For instance, with the resampler SLEP, there needs to be two SLEPs proposing the two solutions, and if one of the is rejected, we don't necessarily want the TC to have to be involved, the slep author can go and modify or have a new one or something. Discussing what will happen in the case of the sleps we already have yesterday, we realized this is an issue which needs to be fixed. |
I'm overall fine with the principle of this suggestion. It is a good one! |
Not sure if this is our most urgent issue but I'm also ok with it |
Co-Authored-By: Gael Varoquaux <[email protected]>
@glemaitre could you also add this to the under review maybe? we can then merge and call the vote. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Adrin said, add the link to under review and change the status in the header. LGTM
slep011/proposal.rst
Outdated
######## | ||
|
||
"[...] If no option can gather two thirds of the votes cast, the decision is | ||
escalated to the TC **if the SLEP proposer would like the SLEP to be accepted**, which in turn will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line too long
The current governance document doesn't require a vote if there is consensus. We have voted on previous SLEPs but there's not really any need to vote for this one, I feel. |
That's an interesting point, which makes it possible to make important decisions w/o announcing on the mailing list beforehand. Might be a bug, not a feature :P |
You think it is? Well then we should... probably fix that first lol? |
Actually, rereading, I think the governance doc is not clear on whether a vote is required :( |
That's an interesting point, which makes it possible to make important decisions w/o announcing on the mailing list beforehand. Might be a bug, not a feature :P
Hum, yes.
|
@GaelVaroquaux did you understand the governance document as always requiring a vote for a SLEP? |
As a side comment, making votes for SLEPs on the mailing list, especially when there is unanimous agreement and all discussion happened in the PR is probably not very relevant for most subscribed users. For most I imagine it's just noise, which will not help in keeping users subscribed/interested. I get that we need some public and temper proof way to record votes, but I wonder if the user mailing list is the best place for it. |
@GaelVaroquaux did you understand the governance document as always requiring a vote for a SLEP?
No I did not, but the point that you raise about SLEPs slipping below the
radar for lack of communication is a good one.
|
This is an alternative path to reduce noise on the mailing list:
|
######## | ||
|
||
This SLEP proposes a change in the decision making process. It proposes to not | ||
always call for a TC vote in case that no consensus is found during the vote of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always call for a TC vote in case that no consensus is found during the vote of | |
always call for a Technical Committee (TC) vote in case that no consensus is found during the vote of |
I made the changes. I think the proposal of @adrinjalali is what I would expect. |
I don't think we need to change anything since the governance model doesn't really specify how it should be done. I'd say we merge, create the next PR to move it as accepted, and call the vote on the mailing list. |
So should we merge this? Or 000? |
With regards to merging this SLEP, I fear that, in it's current state it would add an extra layer of stuff to read. In other terms, I think that we need to consolidate the information somewhere, elsewhere people will have to dig for this information through many layers. Where is that somewhere, I am not certain. Maybe SLEP 000 is a good way to doing that. |
So let's focus on SLEP000 and come back once we have something solid. |
I think that this is a pragmatic view! :) |
No description provided.