Tables #74
Merged
Tables #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I just noticed that in #75, we have this plot Hence at least one of the categorical labeling seems to be incorrect. I think this is related to this bug: scverse/spatialdata-plot#214. |
|
The could be a reappearance of this scverse/spatialdata-plot#104, which in theory was fixed. |
|
will check tomorrow:) there is also the issue with alpha when using color. |
|
but at least the notebook runs |
|
Could be also related to this: scverse/spatialdata-plot#178, but I think it got fixed (and with the new join APIs it would be straightforward to fix). |
Yes! Thanks 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several errors in the aggregation notebook when using the multi_table branch of the SpatialData repo. Also removed commented out code that was commented because of an issue with not being able to plot columns of an element.