Skip to content

"Color by column" now works again #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timtreis
Copy link
Member

No description provided.

@LucaMarconato
Copy link
Member

LucaMarconato commented Jul 13, 2023

I just checked, in the spatial query notebook I get this:

image

While this was what we got in the past:
image

Is this expected? (The samples changed in the raw data, this is fine, I updated the notebook to use the new data).

@timtreis
Copy link
Member Author

Do you mean that both now use blue? I'm rather confused why the old one had two colors

@LucaMarconato
Copy link
Member

Yes. You are right, the all blue plot is actually the correct one.

@timtreis timtreis requested a review from LucaMarconato July 17, 2023 16:28
@timtreis timtreis merged commit cbd454a into main Jul 17, 2023
@timtreis timtreis deleted the bugfix/issue122-color-by-column-functionality-is-broken branch July 17, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color argument breaks pl.render_shapes "color by column" functionality is broken spatial_query tutorial breaks at first plot
2 participants