Remove docs dependencies from default install #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 11 11
Lines 1297 1297
=======================================
Hits 1011 1011
Misses 286 286 |
|
Thank you for your input @aeisenbarth! You're right, gonna merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing just the package spatialdata-plot, it also pulls Sphinx packages. This is a problem, because they have here rather high minimum constraints which conflict with other packages' maximum constraints.
Actually,
myst-nbandsphinx-copybuttonare not needed for spatialdata-plot to run, and are already included in the optional docs dependencies. So it is save to remove them.