Skip to content

Fix passing Colormap objects #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix passing Colormap objects #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/spatialdata_plot/pl/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,12 @@ def _prepare_cmap_norm(
**kwargs: Any,
) -> CmapParams:
is_default = cmap is None
cmap = copy(matplotlib.colormaps[rcParams["image.cmap"] if cmap is None else cmap])
if cmap is None:
cmap = rcParams["image.cmap"]
if isinstance(cmap, str):
cmap = matplotlib.colormaps[cmap]

cmap = copy(cmap)
cmap.set_bad("lightgray" if na_color is None else na_color)

if isinstance(norm, Normalize) or not norm:
Expand Down
0 ...Images_can_pass_cmap_to_render_images.png → ...s_can_pass_cmap_name_to_render_images.png
View file
Open in desktop
File renamed without changes
Binary file added tests/_images/Images_can_pass_cmap_object_to_render_images.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion tests/pl/test_render_images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@ class TestImages(PlotTester, metaclass=PlotTesterMeta):
def test_plot_can_render_image(self, sdata_blobs: SpatialData):
sdata_blobs.pl.render_images(elements="blobs_image").pl.show()

def test_plot_can_pass_cmap_to_render_images(self, sdata_blobs: SpatialData):
def test_plot_can_pass_cmap_name_to_render_images(self, sdata_blobs: SpatialData):
sdata_blobs.pl.render_images(elements="blobs_image", cmap="seismic").pl.show()

def test_plot_can_pass_cmap_object_to_render_images(self, sdata_blobs: SpatialData):
sdata_blobs.pl.render_images(elements="blobs_image", cmap=matplotlib.colormaps["seismic"]).pl.show()

def test_plot_can_render_a_single_channel_from_image(self, sdata_blobs: SpatialData):
sdata_blobs.pl.render_images(elements="blobs_image", channel=0).pl.show()

Expand Down