Skip to content

Minor fix label outline #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Minor fix label outline #231

merged 7 commits into from
Mar 24, 2024

Conversation

melonora
Copy link
Contributor

When the outline for labels was set to False, the outline alpha was still set to 1 causing the outline to still show.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (0ac9f28) to head (91dddad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   77.71%   77.73%   +0.02%     
==========================================
  Files          11       11              
  Lines        1660     1662       +2     
==========================================
+ Hits         1290     1292       +2     
  Misses        370      370              
Files Coverage Δ
src/spatialdata_plot/pl/render.py 94.30% <100.00%> (+0.04%) ⬆️

@melonora melonora merged commit 1d5f361 into scverse:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants