Skip to content

Added error handling for non-existent elements #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Jul 14, 2024

Delegates the check whether an element exists upstream to spatialdata

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (91e5726) to head (8ed8463).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   80.18%   80.21%   +0.03%     
==========================================
  Files          11       11              
  Lines        1736     1739       +3     
==========================================
+ Hits         1392     1395       +3     
  Misses        344      344              
Files Coverage Δ
src/spatialdata_plot/pl/utils.py 69.86% <100.00%> (+0.10%) ⬆️

timtreis added 2 commits July 14, 2024 13:29
…-present-for-labels-points-and-shapes' of github.com:scverse/spatialdata-plot into bugfix/issue294-keyerror-not-raised-when-element-is-not-present-for-labels-points-and-shapes
@timtreis timtreis requested a review from LucaMarconato July 14, 2024 17:31
@timtreis timtreis self-assigned this Jul 14, 2024
@timtreis timtreis requested a review from melonora July 14, 2024 20:11
…ment-is-not-present-for-labels-points-and-shapes
@LucaMarconato LucaMarconato merged commit 1b9b577 into main Jul 15, 2024
5 checks passed
@LucaMarconato LucaMarconato deleted the bugfix/issue294-keyerror-not-raised-when-element-is-not-present-for-labels-points-and-shapes branch July 15, 2024 09:24
@LucaMarconato LucaMarconato restored the bugfix/issue294-keyerror-not-raised-when-element-is-not-present-for-labels-points-and-shapes branch July 15, 2024 09:24
@timtreis timtreis deleted the bugfix/issue294-keyerror-not-raised-when-element-is-not-present-for-labels-points-and-shapes branch July 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError not raised when element is not present, for labels, points and shapes
3 participants