Skip to content

Removed .pp accessor #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Aug 26, 2024

The functionality has since been moved upstream.

@timtreis timtreis linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@timtreis timtreis requested a review from LucaMarconato August 26, 2024 20:30
@timtreis timtreis requested a review from melonora August 27, 2024 18:48
timtreis and others added 7 commits August 27, 2024 21:27
…y-is-now-in-spatialdata' of github.com:scverse/spatialdata-plot into housekeeping/138-remove-pp-accessor-as-its-functionality-is-now-in-spatialdata
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (bd285f6) to head (aab7a19).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   79.26%   79.21%   -0.06%     
==========================================
  Files          11        8       -3     
  Lines        1799     1621     -178     
==========================================
- Hits         1426     1284     -142     
+ Misses        373      337      -36     
Files with missing lines Coverage Δ
src/spatialdata_plot/__init__.py 100.00% <100.00%> (ø)
src/spatialdata_plot/pl/basic.py 90.86% <ø> (-0.05%) ⬇️
src/spatialdata_plot/pl/utils.py 69.09% <93.93%> (+1.04%) ⬆️

Copy link
Collaborator

@Sonja-Stockhaus Sonja-Stockhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@timtreis timtreis merged commit 4e34da3 into main Aug 28, 2024
5 checks passed
@timtreis timtreis deleted the housekeeping/138-remove-pp-accessor-as-its-functionality-is-now-in-spatialdata branch August 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pp accessor as its functionality is now in spatialdata
3 participants