Donut-MultiPolygons are now correctly rendered again #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 79.26% 84.60% +5.33%
==========================================
Files 11 8 -3
Lines 1799 1559 -240
==========================================
- Hits 1426 1319 -107
+ Misses 373 240 -133
|
for more information, see https://pre-commit.ci
timtreis
changed the title
This was referenced Aug 28, 2024
src/spatialdata_plot/pl/utils.py
Outdated
Comment on lines
13
to
15
| import matplotlib.patches | ||
| import matplotlib.patches as mpatches | ||
| import matplotlib.patches as mplp |
There was a problem hiding this comment.
Any particular reason why we need all 3 lines? @timtreis
Sonja-Stockhaus
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extent of the circle is not "perfect", but that's because back then when we first made the plot, we were still doing the extent-calculations "in-house". Now they've been ported upstream so we have no control over them anymore.
(also deleting two unused functions)