Skip to content

Fix validate image parameters method for multiscale images #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Closes #354

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Oct 7, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (6ffe22b) to head (79e3105).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files           8        8           
  Lines        1540     1540           
=======================================
  Hits         1290     1290           
  Misses        250      250           
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/utils.py 76.16% <100.00%> (ø)

@Sonja-Stockhaus Sonja-Stockhaus marked this pull request as ready for review October 7, 2024 20:35
Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@LucaMarconato LucaMarconato merged commit 80c6f77 into main Oct 11, 2024
5 checks passed
@LucaMarconato LucaMarconato deleted the 354-fix_validate_image_params_for_multiscale branch October 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using cmaps fails when rendering multiscale images
3 participants