Skip to content

Transformations are applied before rendering with datashader #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 11, 2024
Merged

Transformations are applied before rendering with datashader #378

merged 13 commits into from
Dec 11, 2024

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Fixes #337

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Oct 25, 2024 that may be closed by this pull request
Points not transformed when method="datashader" #337
Closed
@Sonja-Stockhaus
Copy link
Collaborator Author

Todo: similar for rendering of shapes with datashader

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (bdfd7b5) to head (4016973).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/render.py 94.73% 1 Missing ⚠️
src/spatialdata_plot/pl/utils.py 96.96% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   83.33%   83.52%   +0.18%     
==========================================
  Files           8        8              
  Lines        1650     1687      +37     
==========================================
+ Hits         1375     1409      +34     
- Misses        275      278       +3
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/basic.py 89.21% <ø> (ø)
src/spatialdata_plot/pl/render.py 89.80% <94.73%> (-0.42%) ⬇️
src/spatialdata_plot/pl/utils.py 78.09% <96.96%> (+0.62%) ⬆️

@Sonja-Stockhaus Sonja-Stockhaus mentioned this pull request Oct 25, 2024
Closed
@Sonja-Stockhaus Sonja-Stockhaus mentioned this pull request Nov 27, 2024
Open
@Sonja-Stockhaus Sonja-Stockhaus marked this pull request as ready for review December 3, 2024 20:58
timtreis
timtreis approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@timtreis timtreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timtreis timtreis merged commit e6ed752 into main Dec 11, 2024
5 checks passed
@timtreis timtreis deleted the bugfix/337-ds-point-transformation branch December 11, 2024 17:20
This was referenced Jan 5, 2025
Closed
Closed
@LucaMarconato LucaMarconato mentioned this pull request Feb 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtreis timtreis timtreis approved these changes

Assignees
No one assigned
Labels
release-fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Points not transformed when method="datashader"
4 participants
@Sonja-Stockhaus @codecov-commenter @timtreis @LucaMarconato