Skip to content

Bugfix and Speedup for render_labels #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Apr 4, 2023

Now casting cell_ids to int which fixes an edge-case.
Also sped up the plotting for random colors

@timtreis timtreis linked an issue Apr 4, 2023 that may be closed by this pull request
@timtreis timtreis requested a review from giovp April 4, 2023 14:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #38 (2ae241c) into main (417565c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   33.50%   33.33%   -0.18%     
==========================================
  Files          12       12              
  Lines         764      768       +4     
==========================================
  Hits          256      256              
- Misses        508      512       +4     
Impacted Files Coverage Δ
src/spatialdata_plot/pl/basic.py 11.61% <0.00%> (-0.13%) ⬇️
src/spatialdata_plot/pl/render.py 16.66% <0.00%> (-0.17%) ⬇️

@timtreis timtreis merged commit 5f9917c into main Apr 4, 2023
@timtreis timtreis deleted the bugfix/202304_render_labels_now_casts_instance_ids_to_int branch April 4, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting with random colours is slow
2 participants