Skip to content

Adde guide for visual testing #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Adde guide for visual testing #397

merged 3 commits into from
Dec 23, 2024

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Dec 20, 2024

FYI, this is the command that I use for act:

echo '\033[0;31mremove -r when testing a new branch\033[0m' && time act test --artifact-server-path ~/temp/act --env CODECOV_TOKEN=secret_token_you_need_to_generate --container-architecture linux/arm64 -r -j test 

Please notice that you have to change arm64 to amd64 if you are not using Apple Silicon.
It may work even without the codecov token, please ask me if you encounter problem and I'll help with that.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (49434a3) to head (46b0172).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files           8        8           
  Lines        1689     1689           
=======================================
  Hits         1411     1411           
  Misses        278      278           

@LucaMarconato
Copy link
Member Author

This is my PyCharm configuration for working with the Dockerfile in this repo.
image

@LucaMarconato
Copy link
Member Author

CC @timtreis @Sonja-Stockhaus I made a Dockerfile to ensure reproducibility of the test plots in any local machine. I did this because I was not able to have the tests passing in my MacBook.

I also updated the contribution guide to explain how to update new artifacts.

@LucaMarconato LucaMarconato merged commit e4a0170 into main Dec 23, 2024
5 checks passed
@LucaMarconato LucaMarconato deleted the how-to-test-plots branch December 23, 2024 14:11
@LucaMarconato
Copy link
Member Author

@timtreis I made a mistake and pushed the Dockerfile here 54c0355. I didn't update the CHANGELOG since it's not a new feature/bugfix for users. But I could do it you want.

@timtreis timtreis changed the title Update contributing.md Adde guide for visual testing Jan 20, 2025
@LucaMarconato
Copy link
Member Author

LucaMarconato commented Feb 17, 2025

FYI command to build the image in the spatialdata-plot repo:

docker build --build-arg TARGETPLATFORM=linux/arm64 --tag test-spatialdata-plot -f test.Dockerfile .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants