fix: add logic to convert traits to strings (#763)

* fix: add logic to convert traits to strings

* fix: refactor identify logic based on review

* refactor: move identify event, fix tests, refactor
---------

Author: ashton-huxtable

packages/plugins/plugin-firebase/src/FirebasePlugin.tsx

@@ -5,17 +5,45 @@ import {
   ScreenEventType,
   TrackEventType,
 } from '@segment/analytics-react-native';
-import identify from './methods/identify';
 import screen from './methods/screen';
 import track from './methods/track';
 import reset from './methods/reset';
+import firebaseAnalytics from '@react-native-firebase/analytics';
 
 export class FirebasePlugin extends DestinationPlugin {
   type = PluginType.destination;
   key = 'Firebase';
 
-  identify(event: IdentifyEventType) {
-    identify(event);
+  async identify(event: IdentifyEventType) {
+    if (event.userId !== undefined) {
+      await firebaseAnalytics().setUserId(event.userId!);
+    }
+    if (event.traits) {
+      let eventTraits = event.traits;
+      let safeTraits: Record<string, string>;
+
+      const checkType = (value: unknown) => {
+        return typeof value === 'object' && !Array.isArray(value);
+      };
+      safeTraits = Object.keys(eventTraits).reduce(
+        (acc: Record<string, string>, trait) => {
+          if (checkType(eventTraits[trait])) {
+            this.analytics?.logger.warn(
+              'We detected an object or array data type. Firebase does not accept nested traits.'
+            );
+
+            return acc;
+          }
+          if (trait !== undefined) {
+            acc[trait] = eventTraits[trait]!.toString();
+          }
+          return acc;
+        },
+        {}
+      );
+
+      await firebaseAnalytics().setUserProperties(safeTraits);
+    }
     return event;
   }
 

packages/plugins/plugin-firebase/src/methods/___tests__/identify.test.ts

@@ -1,5 +1,5 @@
 import type { IdentifyEventType } from '@segment/analytics-react-native';
-import identify from '../identify';
+import { FirebasePlugin } from '../../FirebasePlugin';
 
 const mockSetUserId = jest.fn();
 const mockSetUserProperties = jest.fn();
@@ -15,6 +15,7 @@ describe('#identify', () => {
   });
 
   it('forwards the identify event with ID only', async () => {
+    const plugin = new FirebasePlugin();
     const event = {
       type: 'identify',
       userId: '123',
@@ -23,14 +24,15 @@ describe('#identify', () => {
       timestamp: '00000',
     } as IdentifyEventType;
 
-    await identify(event);
+    await plugin.identify(event);
 
     expect(mockSetUserId).toHaveBeenCalledTimes(1);
     expect(mockSetUserProperties).not.toHaveBeenCalled();
     expect(mockSetUserId).toHaveBeenCalledWith('123');
   });
 
   it('forwards the identify event with ID and properties', async () => {
+    const plugin = new FirebasePlugin();
     const event = {
       type: 'identify',
       userId: '123',
@@ -42,7 +44,7 @@ describe('#identify', () => {
       },
     } as IdentifyEventType;
 
-    await identify(event);
+    await plugin.identify(event);
 
     expect(mockSetUserId).toHaveBeenCalledTimes(1);
     expect(mockSetUserProperties).toHaveBeenCalledTimes(1);
@@ -51,6 +53,7 @@ describe('#identify', () => {
   });
 
   it('forwards the identify event without ID', async () => {
+    const plugin = new FirebasePlugin();
     const event = {
       type: 'identify',
       anonymousId: 'anon',
@@ -61,7 +64,7 @@ describe('#identify', () => {
       },
     } as IdentifyEventType;
 
-    await identify(event);
+    await plugin.identify(event);
 
     expect(mockSetUserId).not.toHaveBeenCalled();
     expect(mockSetUserProperties).toHaveBeenCalledTimes(1);