fix: add logic to convert traits to strings #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscb
suggested changes
Feb 21, 2023
oscb
suggested changes
Feb 24, 2023
oscb
approved these changes
Feb 27, 2023
silesky
reviewed
Feb 27, 2023
| (acc: Record<string, string>, trait) => { | ||
| if (checkType(eventTraits[trait])) { | ||
| this.analytics?.logger.warn( | ||
| 'We detected an object or array data type. Firebase does not accept nested traits.' |
There was a problem hiding this comment.
@alanjcharles checkType explicitly does not guard against arrays. Should this message be 'We detected a plain object data type'?
silesky
reviewed
Feb 27, 2023
| } | ||
| if (event.traits) { | ||
| let eventTraits = event.traits; | ||
| let safeTraits: Record<string, string>; |
There was a problem hiding this comment.
why make this a separate declaration? =)
oscb
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [@segment/analytics-react-native-plugin-firebase-v0.3.4](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-firebase-v0.3.3...@segment/analytics-react-native-plugin-firebase-v0.3.4) (2023-02-28) ### Bug Fixes * add logic to convert traits to strings ([#763](#763)) ([559a3bb](559a3bb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.