Skip to content

Commit db38836

Browse files
authored
fix: replace native modules with react-native-uuid (#718)
* fix: replace native modules with react-native-uuid * fix: remove write-key * fix: remove native module uuid test Co-authored-by: Alan Charles <[email protected]>
1 parent dbccc62 commit db38836

File tree

6 files changed

+10
-36
lines changed

6 files changed

+10
-36
lines changed

packages/core/android/src/main/java/com/segmentanalyticsreactnative/AnalyticsReactNativeModule.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ class AnalyticsReactNativeModule : ReactContextBaseJavaModule, ActivityEventList
4646
return "AnalyticsReactNative"
4747
}
4848

49-
@ReactMethod(isBlockingSynchronousMethod = true)
50-
fun getUUIDSync(): String {
51-
return UUID.randomUUID().toString()
52-
}
53-
5449
private fun getBuildNumber(): String {
5550
return PackageInfoCompat.getLongVersionCode(pInfo).toString()
5651
}

packages/core/ios/AnalyticsReactNative.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22

33
@interface RCT_EXTERN_MODULE(AnalyticsReactNative, NSObject)
44

5-
RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(getUUIDSync) {
6-
return [[NSUUID UUID] UUIDString];
7-
}
8-
95
RCT_EXTERN_METHOD(getContextInfo: (NSDictionary)configuration resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
106

117
@end

packages/core/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"@segment/sovran-react-native": "^0.4.5",
5151
"deepmerge": "^4.2.2",
5252
"js-base64": "^3.7.2",
53-
"promise.allsettled": "^1.0.5"
53+
"promise.allsettled": "^1.0.5",
54+
"react-native-uuid": "^2.0.1"
5455
},
5556
"peerDependencies": {
5657
"react": "*",

packages/core/src/__tests__/uuid.test.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/core/src/uuid.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { getNativeModule } from './util';
1+
import uuid from 'react-native-uuid';
22

33
export const getUUID = (): string => {
4-
return getNativeModule('AnalyticsReactNative')?.getUUIDSync() ?? '';
4+
let UUID = uuid.v4().toString();
5+
return UUID;
56
};

yarn.lock

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10658,6 +10658,11 @@ react-native-fbsdk-next@^10.1.0:
1065810658
"@expo/config-plugins" "^4.1.5"
1065910659
xml2js "^0.4.23"
1066010660

10661+
react-native-uuid@^2.0.1:
10662+
version "2.0.1"
10663+
resolved "https://registry.yarnpkg.com/react-native-uuid/-/react-native-uuid-2.0.1.tgz#ed4e2dfb1683eddb66967eb5dca140dfe1abddb9"
10664+
integrity sha512-cptnoIbL53GTCrWlb/+jrDC6tvb7ypIyzbXNJcpR3Vab0mkeaaVd5qnB3f0whXYzS+SMoSQLcUUB0gEWqkPC0g==
10665+
1066110666
react-native@^0.67.2:
1066210667
version "0.67.4"
1066310668
resolved "https://registry.yarnpkg.com/react-native/-/react-native-0.67.4.tgz#57a1503daa81f66a61f521ff67b259f126d87f9c"

0 commit comments

Comments
 (0)