Fix for RNAnalytics not found issue (#30) #116
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirly
approved these changes
Oct 10, 2019
|
I am facing the same error while integrating with firebase. Is this PR going to me merged anytime soon. |
|
will this be merged anytime soon? it's causing build fails for |
|
Can this be merged? Incorrect imports also causing errors in: |
|
Guys any estimation on when this is going to be merged? How are you able to makes these changes in the node_modules, can you explain us @squirly ? |
added 5 commits
January 3, 2020 11:33
xchwarze
approved these changes
Feb 17, 2020
S0c5
approved these changes
Feb 18, 2020
xchwarze
approved these changes
Feb 18, 2020
xchwarze
approved these changes
Feb 18, 2020
bsneed
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RNAnalyticsdependency is missing for all integrations, which needed when it imported inios/main.mfile#import <RNAnalytics/RNAnalytics.h>Also the integration generator will generate factory_header with
Segment-format which causing problem since the right format should beSegment_as an example :Current import ( Invalid ) :
#import <Segment-Adjust/SEGAdjustIntegrationFactory.h>Correct format :
#import <Segment_Adjust/SEGAdjustIntegrationFactory.h>Fix for issue below :
#30