Skip to content

Fix build issue with integrations #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Fix build issue with integrations #153

merged 1 commit into from
Apr 13, 2020

Conversation

dickie81
Copy link
Contributor

When Android running builds I'm getting the following issue:

Build file '/Users/.../node_modules/@segment/analytics-react-native-adjust/android/build.gradle' line: 41

* What went wrong:
A problem occurred evaluating project ':@segment_analytics-react-native-adjust'.
> Project with path ':@segment/analytics-react-native' could not be found in project ':@segment_analytics-react-native-adjust'.

Above change seems to fix.

When Android running builds I'm getting the following issue:

```* Where:
Build file '/Users/dickie/github/ths/trustedhousesitters-next/app/node_modules/@segment/analytics-react-native-adjust/android/build.gradle' line: 41

* What went wrong:
A problem occurred evaluating project ':@segment_analytics-react-native-adjust'.
> Project with path ':@segment/analytics-react-native' could not be found in project ':@segment_analytics-react-native-adjust'.```

Above change seems to fix.
@bsneed
Copy link
Contributor

bsneed commented Mar 30, 2020

@dickie81 thanks for the patch! we've got a couple of more coming later this week, I'll merge this in and push a new release out then.

@bsneed
Copy link
Contributor

bsneed commented Apr 13, 2020

Looks like I did this change by hand in the last release, merging this so you get credit.

@bsneed bsneed merged commit 0edbdbc into segmentio:master Apr 13, 2020
@joaovpmamede
Copy link

@bsneed can this be published to npm?

@bsneed
Copy link
Contributor

bsneed commented Apr 14, 2020

@joaovpmamede The change was in the last beta. Am I incorrect somehow on that?

@joaovpmamede
Copy link

joaovpmamede commented Apr 14, 2020

I think the last beta is 6 days old and this was merged yesterday.

Edit: @bsneed I just read that you had included this change on the last release but somehow I'm still getting the issue reported here with @segment/analytics-react-native-intercom

@bsneed
Copy link
Contributor

bsneed commented Apr 14, 2020

@joaovpmamede I made the change by hand in the previous one. I simply merged this so the author got credit for the fix. Please go have a look, if there is an issue or something I'm missing, do let me know.

@joaovpmamede
Copy link

@bsneed just created a new project, installed the packages and got the same error:

* What went wrong:
A problem occurred evaluating project ':segment_analytics-react-native-intercom'.
> Project with path ':@segment_analytics-react-native' could not be found in project ':segment_analytics-react-native-intercom'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants