feat: plugin-idfa: Add support for iOS 13 and below #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscb
approved these changes
Jun 1, 2022
oscb
pushed a commit
that referenced
this pull request
Jun 24, 2022
## [@segment/analytics-react-native-plugin-idfa-v0.3.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-idfa-v0.2.1...@segment/analytics-react-native-plugin-idfa-v0.3.0) (2022-06-24) ### Features * plugin-idfa: Add support for iOS 13 and below ([#554](#554)) ([40be1ab](40be1ab))
|
🎉 This PR is included in version @segment/analytics-react-native-plugin-idfa-v0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@available(iOS 14, *)attribute didn't prevent this function from being called by react-native / objc runtime. By what seems to be pure luck, on iOS 13 this method implementation is basically a no-op. This PR adds intentional support for iOS 13 and below by moving the iOS 14 check inside the function and handling the < iOS 14 case as well.