Skip to content

fix: appsflyer attribution error due to install conversion data failure #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

fix: appsflyer attribution error due to install conversion data failure #556

merged 1 commit into from
May 31, 2022

Conversation

manueljtejada
Copy link
Contributor

@manueljtejada manueljtejada commented May 31, 2022 •
edited
Loading

This PR prevents the onInstallConversionData handler from throwing an error when the SDK is not able to get the conversion data. In this case, res?.data?.is_first_launch would be undefined and JSON.parse would fail.

Sample payload in onInstallConversionData that would cause this error:

{
  status: 'failure',
  type: 'onInstallConversionFailure',
  data: 'Launch status code: 404'
}

@alanjcharles
Copy link
Contributor

thanks @manueljtejada!

@alanjcharles alanjcharles merged commit 8327bf8 into segmentio:master May 31, 2022
@Asgaroth Asgaroth mentioned this pull request Jun 22, 2022
Closed
oscb pushed a commit that referenced this pull request Jun 24, 2022
@semantic-release-bot
chore(release): 0.3.3 [skip ci]
c4e4df3 
## [@segment/analytics-react-native-plugin-appsflyer-v0.3.3](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-appsflyer-v0.3.2...@segment/analytics-react-native-plugin-appsflyer-v0.3.3) (2022-06-24)

### Bug Fixes

* attribution error due to install conversion data failure ([#556](#556)) ([8327bf8](8327bf8))
@oscb
Copy link
Contributor

oscb commented Jun 24, 2022

🎉 This PR is included in version @segment/analytics-react-native-plugin-appsflyer-v0.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscb oscb added the released label Jun 24, 2022
jezallan pushed a commit to uswitch/analytics-react-native that referenced this pull request Jun 29, 2022
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
b07f107 
## @uswitch/analytics-react-native-plugin-appsflyer-v1.0.0 (2022-06-29)

### Features

* add analytics 2.0 ([segmentio#360](https://github.com/uswitch/analytics-react-native/issues/360)) ([829fc80](829fc80))
* add attribution callbacks to appsflyer ([segmentio#528](https://github.com/uswitch/analytics-react-native/issues/528)) ([b5074f7](b5074f7))

### Bug Fixes

* appsflyer attribution ([segmentio#547](https://github.com/uswitch/analytics-react-native/issues/547)) ([494df24](494df24))
* attribution error due to install conversion data failure ([segmentio#556](https://github.com/uswitch/analytics-react-native/issues/556)) ([8327bf8](8327bf8))
* relative import removed in appsflyer plugin ([segmentio#369](https://github.com/uswitch/analytics-react-native/issues/369)) ([ab23d2e](ab23d2e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manueljtejada @alanjcharles @oscb