-
Notifications
You must be signed in to change notification settings - Fork 197
Feat: Add AdvertisingId Plugin #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b2e428c
chore: lint
alanjcharles 5419616
feat: add advertisingId plugin
alanjcharles 0d3dafa
chore: refactor and add shutdown method
alanjcharles 2c68cd2
chore: debug with oscar
alanjcharles 51518ad
feat: add advertisingId plugin
alanjcharles 76f5349
refactor: rever device_setup.sh
alanjcharles c9220dc
refactor: clean example app update readme
alanjcharles 55f69fc
chore: remove android deps/packages in example
alanjcharles 697267b
chore: remove ad_id permission in manifest
alanjcharles e27ca69
refactor: remove google play services
alanjcharles ad73c6d
refactor: bump ci sdk to 31
alanjcharles c0a3beb
refactor: revert ci changes
alanjcharles 4f75b98
chore: refactor with Oscar's suggestions
alanjcharles 5231b5b
chore:fix yarn conflict
alanjcharles e5a5994
chore: fix yarn.lock
alanjcharles 8a34acd
chore: update device_setup.sh to 31
alanjcharles f611a47
remove google deps
alanjcharles 74c2c9c
chore:revert ci
alanjcharles 93bcca5
chore: refactor ci
alanjcharles dcddebb
refactor: fix tests remove google-services.json from core
alanjcharles 9cbf305
Merge branch 'master' into adId
alanjcharles e955026
Update .github/workflows/ci.yml
alanjcharles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Contributing | ||
|
||
We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project. | ||
|
||
## Adding Android Packages | ||
|
||
Add necessary Gradle Dependencies | ||
|
||
```sh | ||
implementation project(':segmentanalyticsreactnative') | ||
implementation "com.google.android.gms:play-services-ads-identifier:18.0.1" | ||
implementation project(':analyticsreactnativepluginadvertisingid') | ||
``` | ||
|
||
|
||
Add project to `settings.gradle` | ||
|
||
```sh | ||
include ':analyticsreactnativepluginadvertisingid' | ||
project(':analyticsreactnativepluginadvertisingid').projectDir = new File(rootProject.projectDir, '../../packages/plugins/plugin-advertising-id/android') | ||
``` | ||
|
||
Add package to `MainActivity.java` | ||
|
||
```sh | ||
@Override | ||
protected List<ReactPackage> getPackages() { | ||
@SuppressWarnings("UnnecessaryLocalVariable") | ||
List<ReactPackage> packages = new PackageList(this).getPackages(); | ||
// Packages that cannot be autolinked yet can be added manually here, for | ||
// AnalyticsReactNativeExample: | ||
// packages.add(new MyReactNativePackage()); | ||
packages.add(new AnalyticsReactNativePackage()); | ||
packages.add(new AnalyticsReactNativePluginAdvertisingIdPackage()); | ||
return packages; | ||
} | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/core/android/.settings/org.eclipse.buildship.core.prefs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.