feat: support max kB in upload batching #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
approved these changes
Jul 14, 2022
prayansh
reviewed
Jul 14, 2022
| const result: any[] = array.reduce( | ||
| (chunks: any[][], item: any, index: number) => { | ||
| if (maxKB !== undefined) { | ||
| rollingKBSize += sizeOf(item); |
There was a problem hiding this comment.
wont this be more accurate to do in plain bytes rather than kb? we wont have to do the / 1024 everytime we add bytes that way
oscb
pushed a commit
that referenced
this pull request
Jul 15, 2022
## [@segment/analytics-react-native-v2.4.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.3.2...@segment/analytics-react-native-v2.4.0) (2022-07-15) ### Features * spin off the queue handling into a reusable plugin ([#502](#502)) ([55d7988](55d7988)) * support max kB in upload batching ([#600](#600)) ([3dc1957](3dc1957)) ### Bug Fixes * add export for SegmentClient ([#606](#606)) ([ff094f5](ff094f5)) * timeline safe processing events for destinations ([#604](#604)) ([78dcd0e](78dcd0e)) * use storePersistor option in QueueFlushingPlugin ([#602](#602)) ([f7be269](f7be269))
|
🎉 This PR is included in version @segment/analytics-react-native-v2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.