fix: refactor initialization sequence to guarantee readiness before event upload #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjcharles
approved these changes
Feb 23, 2023
oscb
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [@segment/analytics-react-native-v2.13.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.13.0...@segment/analytics-react-native-v2.13.1) (2023-02-28) ### Bug Fixes * refactor initialization sequence to guarantee readiness before event upload ([#765](#765)) ([af21c24](af21c24))
|
🎉 This PR is included in version @segment/analytics-react-native-v2.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
oscb
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [@segment/analytics-react-native-plugin-destination-filters-v1.0.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-destination-filters-v1.0.0...@segment/analytics-react-native-plugin-destination-filters-v1.0.1) (2023-02-28) ### Bug Fixes * refactor initialization sequence to guarantee readiness before event upload ([#765](#765)) ([af21c24](af21c24))
|
🎉 This PR is included in version @segment/analytics-react-native-plugin-destination-filters-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand
initandisStorageReadywould operate asynchronously completely on their own, the second one marking the client as ready for processing events. This was however brittle, as context updates from plugins (IDFA, AdvertisingID) could make the client think it was ready before it would actually load all the relevant information (context, events from previous sessions, settings).This refactors the sequence of initialization so that: storage is always restored first, then settings, context and callbacks are setup (in any order between them), then the client is marked ready.
isReadyreplacesonContextLoadedfor readiness checks.isReadyis a better guarantee as it makes sure it has a full context loaded (either from restoration or from fetching), whereas before it would only check for context from the device get.