Skip to content

add saveDelay option for persistor #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/client.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const createClient = (config: Config) => {
const segmentStore = new SovranStorage({
storeId: config.writeKey,
storePersistor: config.storePersistor,
storePersistorSaveDelay: config.storePersistorSaveDelay,
});

const client = new SegmentClient({
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/plugins/QueueFlushingPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class QueueFlushingPlugin extends UtilityPlugin {
persist: {
storeId: `${config.writeKey}-${this.storeKey}`,
persistor: config.storePersistor,
saveDelay: 0,
saveDelay: config.storePersistorSaveDelay ?? 0,
},
}
);
Expand Down
5 changes: 5 additions & 0 deletions packages/core/src/storage/sovranStorage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ function createStoreGetter<
export class SovranStorage implements Storage {
private storeId: string;
private storePersistor?: Persistor;
private storePersistorSaveDelay?: number;
private readinessStore: Store<ReadinessStore>;
private contextStore: Store<{ context: DeepPartial<Context> }>;
private settingsStore: Store<{ settings: SegmentAPIIntegrations }>;
Expand Down Expand Up @@ -165,6 +166,7 @@ export class SovranStorage implements Storage {
constructor(config: StorageConfig) {
this.storeId = config.storeId;
this.storePersistor = config.storePersistor;
this.storePersistorSaveDelay = config.storePersistorSaveDelay;
this.readinessStore = createStore<ReadinessStore>({
hasRestoredContext: false,
hasRestoredSettings: false,
Expand Down Expand Up @@ -239,6 +241,7 @@ export class SovranStorage implements Storage {
persist: {
storeId: `${this.storeId}-settings`,
persistor: this.storePersistor,
saveDelay: this.storePersistorSaveDelay,
onInitialized: markAsReadyGenerator('hasRestoredSettings'),
},
}
Expand Down Expand Up @@ -274,6 +277,7 @@ export class SovranStorage implements Storage {
persist: {
storeId: `${this.storeId}-filters`,
persistor: this.storePersistor,
saveDelay: this.storePersistorSaveDelay,
onInitialized: markAsReadyGenerator('hasRestoredFilters'),
},
});
Expand Down Expand Up @@ -310,6 +314,7 @@ export class SovranStorage implements Storage {
persist: {
storeId: `${this.storeId}-userInfo`,
persistor: this.storePersistor,
saveDelay: this.storePersistorSaveDelay,
onInitialized: markAsReadyGenerator('hasRestoredUserInfo'),
},
}
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/storage/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,5 @@ export type DeepLinkData = {
export type StorageConfig = {
storeId: string;
storePersistor?: Persistor;
storePersistorSaveDelay?: number;
};
1 change: 1 addition & 0 deletions packages/core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export type Config = {
autoAddSegmentDestination?: boolean;
collectDeviceId?: boolean;
storePersistor?: Persistor;
storePersistorSaveDelay?: number;
proxy?: string;
cdnProxy?: string;
errorHandler?: (error: SegmentError) => void;
Expand Down