fix(async-storage-persistor): Correctly import AsyncStorage #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, we also started seeing this problem. Nice catch @krizzu. |
oscb
approved these changes
May 3, 2023
oscb
pushed a commit
that referenced
this pull request
May 4, 2023
## [@segment/sovran-react-native-v1.0.3](https://github.com/segmentio/analytics-react-native/compare/@segment/sovran-react-native-v1.0.2...@segment/sovran-react-native-v1.0.3) (2023-05-04) ### Bug Fixes * **async-storage-persistor:** Correctly import AsyncStorage ([#820](#820)) ([4ef5883](4ef5883))
|
@oscb Is the sovran version 1.0.3 supposed to be available from npm? The latest version I see on the registry is 1.0.2 https://www.npmjs.com/package/@segment/sovran-react-native?activeTab=readme |
|
Our events have sky rocketed: |
|
@efstathiosntonas can you please write into [email protected], so our support team can investigate the issue with your MTUs? Thank you! |
|
@niallzato thanks, we’re already in an ongoing investigation with segment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently discovered that our Application Install events are rising exponentially. Turns out the store context was not correctly persisted, due to the wrong import on the CommonJS module of AsyncStorage.
Also, I think it'd be great to also mention in docs that users need to use store persistor so that some context events are not repeated on every App start. It's easy to miss in docs and Segment does not provide a default implementation out of the box already set up.